Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SaveScreen::pan_x and SaveScreen::pan_y #1531

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Dec 6, 2018

Fix #1521

  • Units of 1/16th pixel
  • Starts at (0,0) for new game
  • Changes when the screen scrolls due to player movement
    or panning commands.
  • Doesn't change when you teleport.
  • X is always modulo 20 * 256
  • Y is always modulo 10 * 256 (Why not 15??)
  • And thats it...?

Teleporting to different maps doesn't change the pan_x/pan_y. It just starts at (0,0) and increments/decrements forever as you walk around.

I have no clue what this is supposed to be for but thats the behavior I've observed with RPG_RT.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:save_screen branch 2 times, most recently from ac60aa4 to 34e5a09 Dec 6, 2018

@fdelapena fdelapena added the Savegames label Dec 6, 2018

@fdelapena fdelapena added this to the 0.6.0 (likely) milestone Dec 6, 2018

Implement SaveScreen::pan_x and SaveScreen::pan_y
* Units of 1/16th pixel
* Starts at (0,0) for new game
* Changes when the screen scrolls due to player movement
  or panning commands.
* Doesn't change when you teleport.
* X is always modulo 20 * 256
* Y is always modulo 10 * 256 (Why not 15??)
* And thats it...?

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:save_screen branch from 34e5a09 to ac8eea6 Dec 6, 2018

@carstene1ns
Copy link
Member

carstene1ns left a comment

If we ever find a use for them later, is nice to have them in.

@carstene1ns carstene1ns merged commit ad04b8f into EasyRPG:master Dec 6, 2018

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:save_screen branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.