Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support screen flash and pictures #1549

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Dec 9, 2018

This is a quick and dirty way support picture flashing.

We should refactor the rest of the sprites to flash this way and remove screen.cpp.

All flash timing logic is in LSD chunks, so I don't think we need to have flash timing logic in Sprite. Just update the color each frame. Maybe Flash and Tone could be combined into a single color modifier?

@Ghabry

Ghabry approved these changes Dec 10, 2018

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 10, 2018

this has a merge conflict

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 10, 2018

@fmatthew5876 pls also fix the clamp build failure (see jenkins) here

fmatthew5876 added some commits Dec 9, 2018

Support picture flash
* Pictures flashed in rm2k
* Support rm2k3 affected_by_flash flag

Not a good implementation. It adds the feature, but
the whole way we do flashing needs refactored

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:flash branch from f3b617d to 359dcdb Dec 10, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Dec 10, 2018

rebased and added wii fix

@Ghabry Ghabry merged commit d72f561 into EasyRPG:master Dec 10, 2018

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns referenced this pull request Dec 10, 2018

Open

Support RPG Maker 2003 v1.12 #1263

10 of 14 tasks complete

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:flash branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.