Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shop equipment arrows #1590

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Dec 23, 2018

  • Algorithm was wrong
  • Support 2 weapon characters

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:equip_arrow branch 2 times, most recently from 036cd0f to 5d96989 Dec 23, 2018

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 23, 2018

When you are 2-handed and you have 2 one-handed weapons and want to buy a 2-handed weapon where the resulting score is smaller than the sum of the 2 one-handed you will also get an arrow down.

@Ghabry Ghabry added this to the 0.6.0 (likely) milestone Dec 23, 2018

Fix shop equipment arrows
* Algorithm was wrong
* Support 2 weapon characters
* Handle 2 weapon vs 2h weapon

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:equip_arrow branch from 5d96989 to bfb64d8 Dec 23, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Dec 23, 2018

Good catch. Fixed the 2 handed stuff.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 24, 2018

Last merge before Xmas 🎄🎅

@Ghabry Ghabry merged commit 0cf99ba into EasyRPG:master Dec 24, 2018

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:equip_arrow branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.