Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Skill sound for Escape & Teleport (+Transition). Albeleon 1/2 #1591

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
5 participants
@Ghabry
Copy link
Member

Ghabry commented Dec 23, 2018

From #1401

In TransitionOut I added an else case, otherwise the new transition would be overwritten...

These two look legit.

Albeleon added some commits Jul 14, 2018

Generate sound when Skill "Escape": Slow Fadeout from Scene_Skill.
Problem: Using a escape skill doesn't generate its sound and it fades out quickly from the Skill Menu.
Generate skill sound when Skill "Teleport": Slow Fadeout from Scene_T…
…eleport.

Problem: Using a teleport skill generates an item sound instead of the skill sound (even "(OFF)") and it fades out quickly from the Teleport Menu.

@Ghabry Ghabry added this to the 0.6.0 (likely) milestone Dec 23, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 24, 2018

Using an Escape skill item doesn't generate the sound effect here. Can you add that too?

Show resolved Hide resolved src/scene_teleport.cpp Outdated

@carstene1ns carstene1ns merged commit ef802c1 into EasyRPG:master Jan 4, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.