Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle 2k3: Visual fixes for CogDis #1605

Merged
merged 6 commits into from Feb 15, 2019

Conversation

Projects
None yet
4 participants
@Ghabry
Copy link
Member

Ghabry commented Jan 26, 2019

This needs more testing to determine the correct logic but it seems that the condition for choosing between background and terrain is the terrain ID, not a non-empty background.

CogDis animates the background in a fancy way: the front image is only black + transparent and the background is a moving (downwards) mask image which defines the color. And via that trick they get 3 frames of animated stars on the background.

the lack of background->Update() completely broke any background scrolling in battles (upps) and the scrolling was too slow.

The rest fixes issues between Traditional vs Alternative style (still not fully matching but gets closer).

@Ghabry Ghabry added this to the 0.6.0 milestone Jan 26, 2019

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Jan 26, 2019

The first commit is probably wrong, currently doing some more testing.

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Jan 26, 2019

How the animation works, nice trick:

cogdis

Overlayed and moving (ingame the background moves, not the foreground, but result is the same)

cogdis

@fdelapena fdelapena added the Battle label Jan 31, 2019

Show resolved Hide resolved src/spriteset_battle.cpp Outdated
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Feb 3, 2019

We need to verify the first commit doesn't break battle background for:

  • Random encounters with terrain set
  • Random encounters on map with fix background
  • Events which trigger battles with fixed background
  • Events which trigger battles with map setting
    • Where map uses terrain
    • Where map uses fixed bg
  • Whatever the hell the rpg maker editor does for battle test??

Other than that, LGTM 👍

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Feb 6, 2019

To sum up the expected behaviours:

Random encounters:

  • Terrain Based (uses Terrain setting of the tile)
  • Specify: Uses a fixed background
  • Same as parent map

Event command:

  • Defined Map setting
  • Specific background
  • Terrain is background
  • Terrain is fancy

@Ghabry Ghabry force-pushed the Ghabry:battle-2k3 branch from 3ec6884 to ab56d60 Feb 7, 2019

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Feb 7, 2019

BattleTest will be inconvenient to fix as the arguments come via command line as args 5, 6 and 7...

Arg 5: 0 Terrain, 1 Shallow, 2 Deep
Arg 6: 0 Normal, 1 Preempt, 2 Surprise, 3 Sourround, 4 Pincer
Arg 7: When Arg 5 = 0 this is the Terrain ID

@Ghabry Ghabry removed the Needs feedback label Feb 7, 2019

@Ghabry Ghabry referenced this pull request Feb 10, 2019

Open

Mother: Cognitive Dissonance - Issue Documentation #1414

3 of 5 tasks complete

@Ghabry Ghabry force-pushed the Ghabry:battle-2k3 branch from 5a58997 to 6e56271 Feb 10, 2019

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Feb 10, 2019

this is now ready for review

@Ghabry Ghabry referenced this pull request Feb 11, 2019

Open

Final Tear 3: Multiple minor bugs in the battle system #1314

1 of 5 tasks complete

@carstene1ns carstene1ns merged commit 3f2cc2b into EasyRPG:master Feb 15, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.