Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update to SDL2.0.9 #1609

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@Ghabry
Copy link
Member

Ghabry commented Jan 28, 2019

As usual the diff is ugly because of SDL...

Basicly I just patched our stuff into SDLActivity.java as usual and added hidapi-support.

SDL bugfix: On Android < 4.4 the hidapi load must be before SDL load, moved the acquire call up to handle this.

Tested on:
Android 4.1
Android 7.1

Going to send my APK to the one on FB who had crashes.

Compiled APK (uses a different signing key, which means you must uninstall the other app before): https://easyrpg.org/downloads/tmp/EasyRpg209.apk


Fixes #1518.

@Ghabry Ghabry added this to the 0.6.0 milestone Jan 28, 2019

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Jan 29, 2019

FB Feedback: "Works perfectly". So we are good to go

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Jan 29, 2019

Great, will do a test myself later.

@carstene1ns
Copy link
Member

carstene1ns left a comment

"What could possibly go wrong?"

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Feb 6, 2019

Going to push this to the play store beta channel.

@carstene1ns carstene1ns merged commit 47447d3 into EasyRPG:master Feb 6, 2019

7 checks passed

Android (armeabi-v7a) Status overwritten ;)
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
@BlisterB

This comment has been minimized.

Copy link
Member

BlisterB commented Feb 9, 2019

It seems that this update brings a lot of gamepad fixes.
https://www.libsdl.org/tmp/SDL/WhatsNew.txt

I previously tried to implement custom controls for gamepad but faced a lot of bizarre bugs (mostly gamepad not detected after launching a second game), Hopefully it will be better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.