Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Vehicle bgm fix #1620
Note: I use the aboard flag here because that's what tells us the player is actually inside the vehicle. You could have an event that teleports you while boarding and then the bgm effect would not happen.
I tested this parallel event:
The player teleports to the other map, the other map music plays, and then the player boards the ship on that map and the vehicle bgm never plays.
I'll fix that behavior in #1601
You're right, I overlooked that. We actually have
I tested these cases:
The difference matters when boarding the ship. As soon as you start boarding, the player
Feb 7, 2019
There are times when you only need to know if the vehicle is "in use" and other times when it is "boarded". After #1601 we should do a review of this and simplify the API to make this distinction obvious. I expect the majority of cases required boarded.