Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the windowed mode fallback for SDL1.2 #1692

Merged
merged 1 commit into from Mar 12, 2019

Conversation

@BSzili
Copy link
Contributor

commented Mar 12, 2019

The SdlUi::RequestVideoMode function is supposed to have a fallback to windowed mode when neither 320x240 nor 640x480 are available. Due to an oversight the loop always sets the SDL_FULLSCREEN flag at the beginning, so the windowed mode list is never checked, and it gets stuck in and endless loop. I moved the SDL_FULLSCREEN flag setting out of the loop to fix this. I noticed it on AROS, where the VESA driver only has one fixed resolution available after booting.

@carstene1ns
Copy link
Member

left a comment

Good find.

@carstene1ns carstene1ns added this to the 0.6.1 milestone Mar 12, 2019

@carstene1ns carstene1ns added the UX label Mar 12, 2019

@carstene1ns carstene1ns merged commit 1d19012 into EasyRPG:master Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.