Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnterHeroName on bad actor? Report error instead of crash #1719

Merged
merged 1 commit into from May 6, 2019

Conversation

@fmatthew5876
Copy link
Contributor

commented Mar 22, 2019

Fixes Crash 12 of #1666

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:name_crash branch from d44d181 to 9f7294f Mar 22, 2019

@fdelapena fdelapena added this to the 0.6.1 milestone Mar 23, 2019

@Ghabry Ghabry removed the Crash label Mar 26, 2019

@fdelapena fdelapena added the Crash label Mar 30, 2019

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:name_crash branch from 9f7294f to 4b53692 Mar 31, 2019

@carstene1ns carstene1ns requested a review from Ghabry Apr 27, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Well I accept this but I will say again that I dislike the inconsistent use of Output::Error vs. Output::Warning.
See also #858

@Ghabry Ghabry merged commit 255df13 into EasyRPG:master May 6, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

The inconsistent use will be tackled when I do #1720. I want to use Error or some equivalent special error hanndler which logs event code and terminates the game on bad event code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.