Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item + Shake fixes #1745

Merged
merged 4 commits into from Apr 20, 2019

Conversation

@fmatthew5876
Copy link
Contributor

commented Apr 11, 2019

Fix: #1743
Fix: #1744

fmatthew5876 added some commits Apr 11, 2019

Consume skill items when used by menu
Propagate return value from UseSkill so that skill
items get consumed when used by menu.

@fdelapena fdelapena added this to the 0.6.1 milestone Apr 11, 2019

Don't allow equipment skills use: teleport, escape, switch
Matches RPG_RT behavior for rm2k3

@fmatthew5876 fmatthew5876 changed the title Item fixes Item + Shake fixes Apr 11, 2019

Fix out of bounds memory read in shake screen
2k games ported to 2k3 will still have parameters.size() == 4.

Fix: #1743

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:item_fixes branch from 6c3de42 to c667f52 Apr 11, 2019

@Ghabry

Ghabry approved these changes Apr 20, 2019

@carstene1ns carstene1ns merged commit 4f0ce0d into EasyRPG:master Apr 20, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.