Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor character flash #1772

Merged
merged 3 commits into from May 27, 2019

Conversation

@fmatthew5876
Copy link
Contributor

commented May 26, 2019

Use event flash LSD chunks to save and load flash state.
Animate flash from characters update routine.

Fix #1768

All test cases pass, except wait_time chunk which is handled in #1740

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:flash_char branch from f654341 to 5ef51b3 May 26, 2019

@carstene1ns

This comment has been minimized.

Copy link
Member

commented May 26, 2019

Need to be careful here, you messed up g and b all over the place.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:flash_char branch from 5ef51b3 to 7890d28 May 26, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Need to be careful here, you messed up g and b all over the place.

Fixed, Thanks!

@carstene1ns carstene1ns added this to the 0.6.1 milestone May 26, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

I added one more change to fix flash coloring.

See #1768 test case 4. We now match RPG_RT patched with true color support.

fmatthew5876 added some commits May 26, 2019

Refactor character flash
Use event flash LSD chunks to save and load flash state.
Animate flash from characters update routine.
Refactor screen flash
* Handle Wait 0.0s case like RPG_RT (doesn't set time flag)
* Logic matches character flash
Fix flash color scaling
RPG_RT uses flash value [0,31] * 8 to scale to [0,248]. Meaning
there is never 100% saturation.

This was confirmed using a patched RPG_RT with true color support.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:flash_char branch from 4885580 to 5982b7f May 26, 2019

@carstene1ns carstene1ns requested a review from Ghabry May 26, 2019

@Ghabry

Ghabry approved these changes May 27, 2019

@Ghabry Ghabry merged commit 6e7db43 into EasyRPG:master May 27, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.