Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle animation sprites affect by screen flash #1774

Merged
merged 1 commit into from May 27, 2019

Conversation

@fmatthew5876
Copy link
Contributor

commented May 26, 2019

All this flash sprite stuff is due for a larger refactor, we need to remove that quad and flash the sprites individually.

That will be a 6.2 thing. I'm putting this one in to fix #985 for 6.1

Depends on #1772
Fix #985

@carstene1ns carstene1ns added this to the 0.6.1 milestone May 26, 2019

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:anim_fix branch from 4356a16 to 4ca5d46 May 26, 2019

@Ghabry Ghabry added the Needs Rebase label May 27, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 27, 2019

If I see this correctly 3 out of 4 commits are already merged -> Rebase needed

@Ghabry

Ghabry approved these changes May 27, 2019

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:anim_fix branch from 4ca5d46 to 51d7827 May 27, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

rebased

@Ghabry

This comment has been minimized.

Copy link
Member

commented May 27, 2019

@fmatthew5876 to ensure I understand this correctly. This fixes "Shake screen / flash on damage doesn't affect animations. When the enemy uses his physical attack, you can see the last few frames are off as the fake background in the attack animation is offset with the real background" in the linked issue?

@Ghabry Ghabry merged commit f3fb028 into EasyRPG:master May 27, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

Yes it fixes that.

Shake screen already appears to work for battle animations.

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:anim_fix branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.