Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug menu improvements + Teleport to maps #1817

Merged
merged 10 commits into from Jul 6, 2019

Conversation

@fmatthew5876
Copy link
Contributor

commented Jun 13, 2019

Fix: #1813

Also adds some usability improvements to remember indices.

This code is nasty and due for a refactor. I would advise just testing it instead of trying to review some of these diffs...

@Ghabry

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

This code is nasty and due for a refactor.

Haha. I wanted to add something to that scene one week ago and thought the same. The code is really hard to follow/extend. :/

@Ghabry

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

guess this doesn't work in emscripten? In the web player I only get a blackscreen while testing. ( https://easyrpg.org/play/pr1817/?test-play )

Trying it again locally later.

Also not tested yet, need to prepare this: What happens when the maptree has gaps? Are the gaps filles with "ID: (Map unavailable)" lines or will the listing on the left desynchronize with the numbers on the right?

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Gaps are supported. You'll see an empty entry in the list and it'll do nothing when you select it.

Area maps appear in the list but are disabled

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

Added support for Full Heal to the Debug Menu.

I want to add call common event, but that's going to be in 6.2 as it comes after #1779 .

This PR is finished.

@fdelapena fdelapena added this to the 0.6.1 milestone Jun 14, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

Regarding this black screen on emscripten, I see this too.

Maybe it's an async bug related to enabling teleports from scenes other than the map? Do we have any test game setup with quick access to an Escape or Teleport spell?

I suspect this might be a more general issue and if so, they would exhibit the same problem.

EDIT: The error is that async loading doesn't happen.

If you look at the web console, you'll see errors about unable to load MapXXXX.lmu. If you use the feature to teleport to the same map you're on, it works.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

emscripten issue is fixed for debug menu and escape/teleport skills.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

In chat @fdelapena commented that this PR doesn't handle map bounds. Unfortunately I don't think that can be done easily as we actually have to load the lmu file to know the bounds, which would incredibly slow on normal platforms and basically impossible on emscripten.

It's a debug feature, so I guess not a huge problem for now.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:debug_map branch from 5a0e016 to 3d4049d Jun 22, 2019

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:debug_map branch from 3d4049d to 6b12b4b Jun 22, 2019

@Ghabry

Ghabry approved these changes Jul 5, 2019

@Ghabry

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Minor suggestion: When Full Heal is invoked play SFX_UseItem

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Minor suggestion: When Full Heal is invoked play SFX_UseItem

Good idea, added this

src/scene_map.cpp Outdated Show resolved Hide resolved

@Ghabry Ghabry merged commit 9afed23 into EasyRPG:master Jul 6, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.