Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disembark on events with no page + Game_Character cleanups #1828

Merged
merged 6 commits into from Jul 14, 2019

Conversation

@fmatthew5876
Copy link
Contributor

commented Jul 7, 2019

Fixes (some of?) #1827

Other smaller code cleanups and virtual optimizations

Allow disembark on events with no page
* Add comment to fix GetThrough() later
* Devirtualize SetThrough()

@fmatthew5876 fmatthew5876 changed the title Allow disembark on events with no page Allow disembark on events with no page + Game_Character cleanups Jul 7, 2019

@Ghabry Ghabry added this to the 0.6.1 milestone Jul 8, 2019

@Ghabry

Ghabry approved these changes Jul 14, 2019

@Ghabry Ghabry merged commit 2ebdf14 into EasyRPG:master Jul 14, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.