Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Always link against Foundation framework #2267

Merged
merged 8 commits into from Sep 15, 2020
Merged

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Jul 13, 2020

(fix non-SDL2 build such as libretro core)

@Ghabry
Copy link
Member Author

Ghabry commented Jul 14, 2020

Markign this as draft because this fails on Windows with:
"LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library". No idea why, I enforce "/MT" :(

@Ghabry Ghabry marked this pull request as draft Jul 14, 2020
@Ghabry Ghabry marked this pull request as ready for review Sep 15, 2020
@Ghabry
Copy link
Member Author

Ghabry commented Sep 15, 2020

I must have missed this while reading the CMake changelogs:
Since 3.15 they support a new option MSVC_RUNTIME_LIBRARY which finally solves this MT/MD chaos when using Visual Studio.
I set it now automatically based on the VCPKG triplet configuration (which means that only VCPKG works from now on when using MSVC - But we never supported anything else this is even documented).
CMake <3.15 is still supported but I issue noisy warnings.

@Ghabry
Copy link
Member Author

Ghabry commented Sep 15, 2020

I will tag this as "backport to stable". It is veeeery unlikely that there will be a new stable release (I can just cherry-pick these commits in the libretro fork) but just in case.

@Ghabry Ghabry added the backport to stable Pull requests with changes backported to our stable, maintenance branch label Sep 15, 2020
@Ghabry
Copy link
Member Author

Ghabry commented Sep 15, 2020

Don't merge yet. I found another problem when compiling libretro-core I currently solve. ... fPIC problems >.>

A shared library causes problems here because of the runtime path and the only use-case here is to link with the Player.

This also solves a problem when BUILD_SHARED_LIBS is on for the libretro core, before liblcf was built as a .so and the core loading failed.
@Ghabry
Copy link
Member Author

Ghabry commented Sep 15, 2020

now is done

Ghabry added 2 commits Sep 15, 2020
…red library

Otherwise this gives linking errors because of missing relocations
The idea years ago was to use this for unit testing but Mocking and regression testing made this obsolete
@fdelapena fdelapena added this to the 0.6.3 milestone Sep 15, 2020
@fdelapena fdelapena merged commit a51fdf7 into EasyRPG:master Sep 15, 2020
7 checks passed
@Ghabry Ghabry deleted the macos branch May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to stable Pull requests with changes backported to our stable, maintenance branch Building macOS
Development

Successfully merging this pull request may close these issues.

None yet

3 participants