Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enemy default state rank #2332

Merged
merged 1 commit into from Sep 15, 2020
Merged

Fix enemy default state rank #2332

merged 1 commit into from Sep 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2020

The default state rank of an enemy is only "B" instead of "C". All the other default ranks (enemy attribute rank, player state rank and player attribute rank) are already correct.

The default state rank of an enemy is only "B" instead of "C".
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Sep 12, 2020

Nice catch!

@fdelapena fdelapena added this to the 0.6.3 milestone Sep 12, 2020
Ghabry
Ghabry approved these changes Sep 15, 2020
Copy link
Member

@Ghabry Ghabry left a comment

Confirmed, the chunk is not written for the B-case

@Ghabry Ghabry merged commit e3fdcbc into EasyRPG:master Sep 15, 2020
7 checks passed
@Ghabry
Copy link
Member

Ghabry commented Sep 15, 2020

@fmatthew5876
Also liblcf should be checked if we handle this correctly.

@Ghabry Ghabry added the backport to stable Pull requests with changes backported to our stable, maintenance branch label Sep 15, 2020
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Sep 15, 2020

I believe it does, considering that we tested reading and writing an empty database.

@ghost ghost deleted the enemy-staterank branch Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to stable Pull requests with changes backported to our stable, maintenance branch Battle
Development

Successfully merging this pull request may close these issues.

None yet

3 participants