Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle: Absorb only HP if the target gets killed by the absorption #2351

Merged
merged 1 commit into from Sep 24, 2020
Merged

Battle: Absorb only HP if the target gets killed by the absorption #2351

merged 1 commit into from Sep 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 23, 2020

If a target gets killed by an absorption skill, then only the HP are absorbed.

@Ghabry
Copy link
Member

Ghabry commented Sep 23, 2020

Slowly this should be refactored..... except for the stat type this is 4 times the same code which becomes more complex with each PR.

@fmatthew5876
Copy link
Contributor

Slowly this should be refactored..... except for the stat type this is 4 times the same code which becomes more complex with each PR.

It's coming in my next PR, don't worry :)

@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Sep 24, 2020

@rueter37 Are you certain that absorption even works at all for atk, def, spi, and agi?

I'm looking at RE and I don't see this at all. I only see absorb logic for HP and SP.

I checked both dynrpg and 2k3e. Can you please confirm with a test? If it's not the case, then we should remove that logic in this PR.

@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Sep 24, 2020

Ok I just tested this myself.

  1. Attack enemy ~ 260 dmg
  2. Use a skill which absorbs 9999 atk
  3. Attack enemy ~ 260 dmg
  4. Use skill on self which raises atk by 9999
  5. Attack enemy ~ 750 dmg

So clearly absorb does not work for parameters outside of hp and sp

Unless I've missed something, please fix the absorb logic for parameters in this PR.

If a target gets killed by an absorption skill, then only the HP are
absorbed. Moreover attack, defense, spirit and agility cannot be
absorbed even in RPG Maker 2003.
@ghost
Copy link
Author

ghost commented Sep 24, 2020

Did some retests and confirmed you are right. Attack, defense, spirit and agility really cannot be absorbed even in RPG Maker 2003. I have updated this PR.

@fmatthew5876 fmatthew5876 merged commit b3c44e8 into EasyRPG:master Sep 24, 2020
@ghost ghost deleted the skills-absorbfix branch September 24, 2020 17:16
@Ghabry Ghabry added this to the 0.6.3 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants