Skills which targets allies ignore hidden targets

[ghost]

If an enemy uses a skill which targets all his allies then his hidden allies are no longer targeted anymore.

[Ghabry]

Is this a regression?
Take a look at #2107 first commit 192943d
Why isn't that change sufficient here?

[ghost]

It is because if the skill.scope is Scope_ally or Scope_party then the return GetTarget()->Exists() is never reached because it gets caught by return true. We have no regression here, the problem mentioned here already existed before #2107 was merged.

[Ghabry]

ah okay, so this is an edge-case we didn't consider.

@rueter37
Could you please stop for the next hours to push any commits onto Github? (at least not into branches where you have open PRs)

Want to release Player 0.6.2.3 today which fixes the absorb crash. As these releases are created via backporting commits (https://github.com/EasyRPG/Player/tree/0-6-2-stable). I must recompile liblcf and this will take a long time when anybody pushes commits because this will make the builders busy.
Thank you!

[ghost]

Acknowledged. 👍