Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle 2k3: Add run away animation on escape #2383

Merged
merged 1 commit into from Oct 11, 2020
Merged

Battle 2k3: Add run away animation on escape #2383

merged 1 commit into from Oct 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2020

Depends on #2364

If the escape command is used in RPG Maker 2003 battles, the actors do a run away animation now. This fixes the second bullet point of #2147.

Fix #2147

@fdelapena fdelapena added Battle Has PR Dependencies This PR depends on another PR labels Oct 6, 2020
@fdelapena fdelapena added this to the 0.6.3 milestone Oct 11, 2020
If the escape command is used in RPG Maker 2003 battles, the actors
do a run away animation now.
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The speed of there movement looks correct, I made a recording to verify this.

But: In RPG_RT they seem to play some kind of "walking animation". That changes every 3-4 frames. Can you try to figure out which animation state that is?

@ghost
Copy link
Author

ghost commented Oct 11, 2020

The animation state is set to AnimationState_WalkingLeft or AnimationState_WalkingRight depending on the direction the actor flees. I'm pretty sure the walking animation works, I have reduced the speed from 6 to 1 in my test to verify that the animation works. 6 is pretty fast, it is possible to not notice the walking animation in this case.

@Ghabry Ghabry removed the Has PR Dependencies This PR depends on another PR label Oct 11, 2020
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this time the animation worked for me, no idea what happened last time

@fmatthew5876 fmatthew5876 merged commit 15633b5 into EasyRPG:master Oct 11, 2020
@ghost ghost deleted the issue-2147-2 branch October 12, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Battle 2k3: Misc issues
3 participants