Fixes for NovemberJoy's remaining battle issues #2481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Ghabry
added
Awaiting Rebase
ghost
marked this pull request as ready for review
fdelapena
removed
the
Awaiting Rebase
fdelapena
approved these changes
Mar 22, 2021
mateofio
reviewed
Mar 25, 2021
src/scene_battle_rpg2k3.cpp
Outdated
| } | ||
| } | ||
|
|
||
| if (action->IsSuccess() && target->GetType() == Game_Battler::Type_Ally && target->IsDead()) { |
Contributor
There was a problem hiding this comment.
A better condition is !was_dead && target->GetType() == Game_Battler::Type_Ally && target->IsDead(). Then you're guaranteed to change the state only when the actor is killed by the action but not when they happen to already be dead and some battle action was successful.
Ghabry
approved these changes
Mar 25, 2021
Member
Ghabry
left a comment
Ghabry
left a comment
There was a problem hiding this comment.
The code looks fine and I trust rueter that they did lots of testing to ensure this works as expected.
I'm far less knowledgeable in how the battle system should behave.
So when fmatthews concern is addressed can be merged.
added 2 commits
March 25, 2021 17:31
Dead characters play the death animation only once now.
If an enemy starts a normal attack, do not wait for the battle animation.
mateofio
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the death animation loop by playing death animations only once (RPG_RT does this as well) and normal enemy attacks do not longer wait for the battle animation (you will see the animation and the damage number at the same time like in RPG_RT). This affects RPG Maker 2003 battles.
Fixes: #1681
Fixes: #2335