Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement customizable enemy unarmed battle animation #2498

Merged
merged 1 commit into from Mar 26, 2021
Merged

Implement customizable enemy unarmed battle animation #2498

merged 1 commit into from Mar 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2021

This PR allows to set the unarmed battle animation of an enemy via the "maniac_unarmed_animation" setting in the LCF database. This fixes the first bullet point in #2497.

src/game_enemy.h Outdated Show resolved Hide resolved
@Ghabry
Copy link
Member

Ghabry commented Mar 22, 2021

This was fast. Did you also test it in RPG_RT with Maniac Patch?

@ghost
Copy link
Author

ghost commented Mar 22, 2021

Unfortunately not.

@Ghabry Ghabry added Has PR Dependencies This PR depends on another PR Battle Needs feedback Waiting for the issue author to give further information. RPG_RT Patches and removed Has PR Dependencies This PR depends on another PR labels Mar 22, 2021
The unarmed battle animation of an enemy can now be set via the
"maniac_unarmed_animation" setting in the LCF database.
@fdelapena fdelapena added this to the 0.6.3 milestone Mar 22, 2021
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test before merge (my job^^)

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work even if the maniac patch is unused, since we default on 1 in liblcf.

@Ghabry
Copy link
Member

Ghabry commented Mar 23, 2021

Yeah, but this is less sloppy. For RPG2k3E we are quite sloppy with the chunk handling everywhere, e.g. "Skip title" works in all engines but should only work in 2k3E :/

@Ghabry Ghabry mentioned this pull request Mar 26, 2021
10 tasks
@Ghabry Ghabry removed the Needs feedback Waiting for the issue author to give further information. label Mar 26, 2021
@Ghabry Ghabry merged commit 07fe5ef into EasyRPG:master Mar 26, 2021
@ghost ghost deleted the enemy-unarmed-animation branch March 26, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants