Fix ExFont extraction in Grimm's Hollow #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntries but this assumption did not work for Grimm's Hollow resulting in a corrupted image and heap corruption. Also fixed how num_colors in the header is populated: When the value is 0 the value must be the maximum allowed. Required for the ExFont logic and for our duplicate color detection logic.
fdelapena
approved these changes
Apr 18, 2021
fmatthew5876
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by doing a more sophisticated Bitmap header building. Grimms Hollow used 4 palette entries but we hardcoded it to 256.
I checked the sourcecode of wrestool (line 303) https://fossies.org/linux/icoutils/wrestool/extract.c to ensure that this logic is correct.
Reported via
https://community.easyrpg.org/t/retroarch-easyrpg-bug-grimms-hollow-missing-star-glyph/952