Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExFont extraction in Grimm's Hollow #2512

Merged
merged 1 commit into from
May 1, 2021
Merged

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Apr 18, 2021

... by doing a more sophisticated Bitmap header building. Grimms Hollow used 4 palette entries but we hardcoded it to 256.

I checked the sourcecode of wrestool (line 303) https://fossies.org/linux/icoutils/wrestool/extract.c to ensure that this logic is correct.

Reported via
https://community.easyrpg.org/t/retroarch-easyrpg-bug-grimms-hollow-missing-star-glyph/952

@Ghabry Ghabry added the Bitmaps label Apr 18, 2021
@Ghabry Ghabry added this to the 0.6.3 milestone Apr 18, 2021
…ntries but this assumption did not work for Grimm's Hollow resulting in a corrupted image and heap corruption.

Also fixed how num_colors in the header is populated:
When the value is 0 the value must be the maximum allowed. Required for the ExFont logic and for our duplicate color detection logic.
@fmatthew5876 fmatthew5876 merged commit 6f2f0a6 into EasyRPG:master May 1, 2021
@Ghabry Ghabry deleted the exfont branch May 27, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants