Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encode + #2514

Merged
merged 1 commit into from
May 1, 2021
Merged

URL encode + #2514

merged 1 commit into from
May 1, 2021

Conversation

krmbn0576
Copy link
Contributor

Some servers (e.g. CloudFront) will not respond properly if the file name contains +, such as a+b.png.

Therefore, URL encoding is helpful. (See also #894)

@fdelapena fdelapena added the Emscripten WebAssembly/JavaScript port for web browsers label Apr 27, 2021
@fdelapena fdelapena added this to the 0.6.3 milestone Apr 27, 2021
@fdelapena fdelapena requested a review from Ghabry April 27, 2021 04:44
@Ghabry
Copy link
Member

Ghabry commented May 1, 2021

Jenkins: Test this please

Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not seeing a problem with this. Thanks

@Ghabry Ghabry merged commit 86ec910 into EasyRPG:master May 1, 2021
@Ghabry
Copy link
Member

Ghabry commented May 3, 2021

uhm yeah this completely breaks emscripten because the "+" is a regex that matches the entire string...

I will add a string.replaceall function to ensure that this never happens again -_-

@krmbn0576
Copy link
Contributor Author

sorry for my wrong pull request, and thanks for fixing it correctly in #2435 👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emscripten WebAssembly/JavaScript port for web browsers
Development

Successfully merging this pull request may close these issues.

None yet

3 participants