Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten: Improve engine and patch detection. #2520

Merged
merged 2 commits into from May 10, 2021

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented May 5, 2021

Check for certain files in the index.json and create empty versions of them.

This ensures that RPG Maker 2003 English, DynRPG Patch and Maniacs Patch are detected properly.


Yeah I know this solution is kinda hacky (like many parts of the Web Player :P). But it works.

(This conflicts with the VFS branch but this change is so minimal that adopting it is no huge problem)


Before: https://easyrpg.org/play/master/?game=frozen_triggers
After: https://easyrpg.org/play/pr2520/?game=frozen_triggers

Fix #2526

Check for certain files in the index.json and create empty versions of them.

This ensures that RPG Maker 2003 English, DynRPG Patch and Maniacs Patch are detected properly.
@Ghabry Ghabry added the Emscripten WebAssembly/JavaScript port for web browsers label May 5, 2021
@Ghabry Ghabry added this to the 0.7.0 milestone May 5, 2021
Emscripten handles this by now and this fixes games where the folders were renamed (e.g. FaceSet -> Faceset)
@Ghabry
Copy link
Member Author

Ghabry commented May 10, 2021

No idea when they fixed this but emscripten-wget functions create the folder structures by now, so our mkdir trickery can be removed.

@fdelapena Imo this can be merged without further reviews. The others are MIA and this is very simply

@fdelapena fdelapena merged commit 1fd6e74 into EasyRPG:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emscripten WebAssembly/JavaScript port for web browsers
Development

Successfully merging this pull request may close these issues.

HTML 5 - Show Picture // Spritesheet
2 participants