Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Rebind key used for fast forward x10 on desktop versions #2544

Merged
merged 1 commit into from May 31, 2021
Merged

Input: Rebind key used for fast forward x10 on desktop versions #2544

merged 1 commit into from May 31, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2021

This PR rebinds the fast forward x10 function from the F and NumPlus keys to the G key on desktop versions. This feature was suggested by rpgguest4188 and supported by Fran[e]1 on March 8, 2021 according to the IRC chatlog. I'm supporting this feature request myself, because it is much more convenient not having to use two hands for the fast forward x10 function. One more advantage is that the change stops interferences with some RPG Maker 2003 games which use the NumPlus key for certain events. This change doesn't interfere with the current input scheme as the G key is currently unused.

In the desktop version of EasyRPG Player fast forward x10 is now
bound on the 'G' key.
@fdelapena fdelapena added the UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design label May 23, 2021
@fdelapena fdelapena added this to the 0.7.0 milestone May 23, 2021
@Ghabry
Copy link
Member

Ghabry commented May 26, 2021

I'm not sure if adding another key is really an option for this. I would directly delete it again when the Scene_Config is ready (and put a fast forward multiplier config in there, just like Android).

How about: Instead of using PLUS for x10 you could use "F-Held + PLUS-Toggled" and "F-Held + MINUS-Toggled" for "Increase/Decrease multiplier by 1 in range [2, 10]". (toggled as in "pressed once", then you can configure this once on game start)

@ghost
Copy link
Author

ghost commented May 27, 2021

Well, I have use cases where I want fast forward x3 (RPG Maker 2003 battles) and where I want fast forward x10 (Traversing large empty or bland maps, skipping long cutscenes). Having two separate keys is more convenient for me. I personally don't like the idea to hit "F + Plus" and "F + Minus" seven times everytime to switch between fast forward x3 and x10.

Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay for now. Can be revisited when we have a config scene.

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using this… shrug

@carstene1ns carstene1ns merged commit 78f17e7 into EasyRPG:master May 31, 2021
@Ghabry
Copy link
Member

Ghabry commented May 31, 2021

Not using this? That's the only way to make random encounters and walking simulators like Yume Nikki bearable xD.

@ghost ghost deleted the rebind-fastforward-plus branch May 31, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design
Development

Successfully merging this pull request may close these issues.

None yet

3 participants