Change sound volume scaling #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdelapena
approved these changes
Jun 1, 2021
The sound volume scaling method has been changed.
Ghabry
approved these changes
Jun 7, 2021
carstene1ns
approved these changes
Jun 7, 2021
|
in that case would prefer a function (in an anonymous namespace in the cpp) in Game_System. Could take the volume by reference and alter it. |
The new volume scale has been moved into an own function. Calling this function converts the volume given from linear to a logarithmic scale.
|
Sorry, I didn't know that I was supposed to make further changes. I hope I added the function the right way. |
ghost
deleted the
|
hmpf and of course this fails to compile on the 3DS because int32_t is not int there 😅 |
|
oh I see now another flaw: This adjusted volume is also written in certain chunks. This shouldn't happen. Will also fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the volume scaling method of the sound and music effects from linear to a logarithmic scale. This aims to fix some sound volume issues reported in #2236.
Related: #2236