Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment scene: Do not show equippable items on fixed equipment #2576

Merged
merged 2 commits into from Jul 19, 2021
Merged

Equipment scene: Do not show equippable items on fixed equipment #2576

merged 2 commits into from Jul 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2021

This PR hides the equippable items in the equipment scene if the selected actor has the fixed equipment flag set (According to this comment the equipment scene should behave this way).

If an actor has the fixed equipment flag set then do not show
equippable items in the equipment scene for this actor.
@fdelapena fdelapena added this to the 0.7.0 milestone Jul 12, 2021
@Ghabry
Copy link
Member

Ghabry commented Jul 18, 2021

I checked now all possible cases:

  • Actor: Fixed Equip: Equipment hidden
  • Item: Cannot unequip: Equpiment shown
  • States: Fixed Equip: Equipment was be shown (this is wrong right now)

Will add a commit to fix this as this was my sloppy testing :)

…rol for the equipment scene (when cursed by skill the inventory is shown)
@Ghabry
Copy link
Member

Ghabry commented Jul 18, 2021

addressed this edge-case now

@Ghabry
Copy link
Member

Ghabry commented Jul 19, 2021

Jenkins: Test this please

@Ghabry Ghabry merged commit 9804380 into EasyRPG:master Jul 19, 2021
@ghost ghost deleted the hide-equippable-items-on-fixed-equipment branch August 22, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants