Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change menu cursor scrolling speed #2634

Merged
merged 1 commit into from Sep 7, 2021
Merged

Change menu cursor scrolling speed #2634

merged 1 commit into from Sep 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2021

This PR decreases the interval between two menu cursor scrolls to 4 frames and increases the initial delay to 23 frames.

This is a partial fix for #2574. Still missing is the "smooth scrolling" stuff in the shop window.

@fdelapena fdelapena added this to the 0.7.0 milestone Sep 4, 2021
@ghost
Copy link
Author

ghost commented Sep 6, 2021

Did more tests and found that a initial delay of 25 frames is too slow. But the old value (20 frames) is too fast, so I went with a initial delay of 22 frames. It feels right for me, but getting the absolutely correct value requires decompilation of RPG_RT.

@Ghabry
Copy link
Member

Ghabry commented Sep 6, 2021

decompiling this is hard because this is not a part we ever investigated.

I did a 60 FPS recording instead and then counted this multiple times (framedrops...)

In most cases I got "23 frames" for the first and "4 frames" for the repeating.

The interval between two menu cursor scrolls has been decreased
to 4 frames and the initial delay increased to 23 frames.
This partially fixes issue 2574.
@ghost
Copy link
Author

ghost commented Sep 7, 2021

@Ghabry I have changed the initial delay to 23 frames now. So everything should be right now.

@Ghabry Ghabry merged commit 306ff9a into EasyRPG:master Sep 7, 2021
@ghost ghost deleted the issue-2574 branch September 9, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants