Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abort event hotkey in debug mode #2660

Merged
merged 1 commit into from Oct 16, 2021
Merged

Implement abort event hotkey in debug mode #2660

merged 1 commit into from Oct 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2021

This PR enables aborting the active foreground event in debug mode by pressing the F10 key and moves the screenshot hotkey to the F7 key.

Fixes: #2314

@@ -73,6 +73,7 @@ namespace Input {
FAST_FORWARD_PLUS,
TOGGLE_FULLSCREEN,
TOGGLE_ZOOM,
DEBUG_ABORT_EVENT,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you move this next to the other DEBUG stuff?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just noticed you must also add it to kButtonNames and kButtonHelp. They will be used by the settings scene later

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added DEBUG_ABORT_EVENT to kButtonNamesand kButtonHelp now. While this PR doesn't add the settings menu, SETTINGS_MENU has been added to kButtonNames because kButtonNames and kButtonHelp were in a inconsistent state (39 vs. 40 entries). In kButtonHelp was already a description for SETTINGS_MENU while this one was missing in kButtonNames.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I noticed something similiar with the key names when I readded the input display to the settings scene: When I added additional keyboard keys I forgot to add them to names and help, making the settings-input scene instant-crash...

@Ghabry Ghabry added this to the 0.7.0 milestone Oct 3, 2021
In debug mode the active foreground event can be aborted now by
pressing the F10 key. The screenshot hotkey has been moved to the
F7 key.
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in RPG_RT:

  1. Calls an unknown function in Window Message (purpose likely the same)
  2. Unconditional call to FinishMoveRoute (so no if-check)
  3. Ends event processing

So you are pretty accurate ^^

@Ghabry Ghabry requested a review from fdelapena October 14, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Implement abort event hotkey in test play mode
2 participants