Extend allowed tempo range for BGMs and SEs #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you make some tests to ensure that this still works fine? (I couldn't see why not but... :)) |
|
Well, while the entire range works for me, I don't recommend using values below 25%. This is way too slow then (but still works). |
|
Could you add comments to both changes? "Normal pitch is 50 to 200 but Yume2kki uses out of range values" |
The allowed tempo range for BGMs and SEs is now extended from 50-200% to 10-400%.
|
Comments have been added now. |
Ghabry
approved these changes
Dec 22, 2021
fdelapena
approved these changes
Dec 27, 2021
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the allowed tempo range for BGMs and SEs from 50-200% to 10-400%.
Fixes: #2590