FileSystem: Support / and drive:/ #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Unit Test for subfolder search in ZIP
carstene1ns
approved these changes
May 20, 2022
fdelapena
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Havn't done any hardware tests yet, only operated on
/and--project-path romfs:/to verify this behaviourWhen using
/as the--project-paththe/was removed making this empty string which is then handled as the working directory (is silently converted to.at the important places). This is completely wrong.Similiar problem with drive letters (
drive:/). Windows does not care if you useC:orC:/, which is what I used for testing here.Unfortunately ctrulib and others are more strict here and want the
/.Fixing this was not that terrible.
Functions that are drive-aware now:
MakeCanonical,GetPathAndFilename, the substring calculation inFindFile.Also added Unit Tests to verify this behaviour.