Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipFs: Disable built-in cache #2788

Merged
merged 2 commits into from
May 23, 2022
Merged

ZipFs: Disable built-in cache #2788

merged 2 commits into from
May 23, 2022

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented May 20, 2022

The Zip FS cached all the decompressed files in memory.

This is very wasteful in terms of RAM making this unusable on many devices.

In general a compressed read + decompress will be still faster than a uncompressed read because IO is much slower than CPU.

Also in most cases the decompress only happens once. We already have caching for assets. BGM is also never decompressed until the track changes.

carstene1ns and others added 2 commits May 20, 2022 18:04
We have already enough caching layers, so this just wastes RAM and makes the feature unusable on low spec devices.
@fdelapena fdelapena modified the milestones: 0.8.0, 0.7.1 May 21, 2022
@fdelapena fdelapena added the Performance Related to improvements on memory, less CPU or disk usage, battery savings, etc. label May 21, 2022
@fdelapena fdelapena merged commit ec5f4fd into EasyRPG:master May 23, 2022
@Ghabry Ghabry deleted the zip-no-cache branch May 29, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FileFinder Performance Related to improvements on memory, less CPU or disk usage, battery savings, etc.
Development

Successfully merging this pull request may close these issues.

3 participants