-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3DS: 2 bugfixes, 1 feature, a bit of cleanup #2827
3DS: 2 bugfixes, 1 feature, a bit of cleanup #2827
Conversation
carstene1ns
commented
Jul 17, 2022
•
edited
Loading
edited
|
||
ndspChnWaveBufAdd(ndsp_channel, &se_buf[se_channel]); | ||
mix[0] = mix[1] = volume / 100.0f; | ||
ndspChnSetMix(chan, mix); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a second Bugfix (note channel 0 was used before).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Battery status feature looks great, but I feel tones look a bit bright/saturated compared to the existing ones on the dark keypad design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the audio fixes.
I agree with fdelapenas nits but for homebrew we usually accept even "not 100% perfect" contributions. So would be fine if the nits are resolved in a follow up PR (though don't think anybody will complain soon xD)
b4fe0c9
to
2ce9c0f
Compare
Add APT hooks (close lid, etc) Add battery monitoring (charging, level) Considering to increase linear heap a bit (might fix display glitches) Fix bug: always turn bottom screen on when closing The battery images were provided by chat user trailboss. Thanks!
2ce9c0f
to
89c5988
Compare