Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DS: 2 bugfixes, 1 feature, a bit of cleanup #2827

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

carstene1ns
Copy link
Member

@carstene1ns carstene1ns commented Jul 17, 2022

ttt

@carstene1ns carstene1ns added this to the 0.7.1 milestone Jul 17, 2022

ndspChnWaveBufAdd(ndsp_channel, &se_buf[se_channel]);
mix[0] = mix[1] = volume / 100.0f;
ndspChnSetMix(chan, mix);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a second Bugfix (note channel 0 was used before).

@carstene1ns carstene1ns changed the title 3DS: 1 bugfix, 1 feature, a bit of cleanup 3DS: 2 bugfixes, 1 feature, a bit of cleanup Jul 18, 2022
@fdelapena fdelapena requested a review from Ghabry July 31, 2022 20:01
Copy link
Contributor

@fdelapena fdelapena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Battery status feature looks great, but I feel tones look a bit bright/saturated compared to the existing ones on the dark keypad design.

src/platform/3ds/audio.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the audio fixes.

I agree with fdelapenas nits but for homebrew we usually accept even "not 100% perfect" contributions. So would be fine if the nits are resolved in a follow up PR (though don't think anybody will complain soon xD)

@Ghabry
Copy link
Member

Ghabry commented Aug 21, 2022

Battery indicators provided by trailboss

battery2

@carstene1ns carstene1ns force-pushed the feature/3ds-hooks-and-info branch from b4fe0c9 to 2ce9c0f Compare September 2, 2022 22:52
@fdelapena fdelapena added the Awaiting Rebase Pull requests with conflicting files due to former merge label Sep 12, 2022
Add APT hooks (close lid, etc)
Add battery monitoring (charging, level)
Considering to increase linear heap a bit (might fix display glitches)
Fix bug: always turn bottom screen on when closing

The battery images were provided by chat user trailboss. Thanks!
@carstene1ns carstene1ns force-pushed the feature/3ds-hooks-and-info branch from 2ce9c0f to 89c5988 Compare September 22, 2022 21:05
@carstene1ns carstene1ns removed the Awaiting Rebase Pull requests with conflicting files due to former merge label Sep 22, 2022
@Ghabry Ghabry merged commit e8610d4 into EasyRPG:master Sep 23, 2022
@carstene1ns carstene1ns deleted the feature/3ds-hooks-and-info branch July 26, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants