Emscripten viewport #2900
Merged
Emscripten viewport #2900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is possible thanks to new settings ui handling everything.
Ghabry
force-pushed
the
emscripten-viewport
branch
from
56c6d37 to
881352a
Compare
|
two problems:
|
|
Rendering looks now much better because the size of the canvas matches the sdl2 window: Bilinear: left old, right new
Integer: left old, right new
|
fdelapena
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the media-queries and instead uses the entire available area.
Our SDL2 code handles it internally now since the settings PR
for best comparison I recommend opening https://easyrpg.org/play/master and https://easyrpg.org/play/pr2900 on a phone or any other very high dpi display and toggle fullscreen. The difference is extreme.