Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Resolution 3/?, Config 4/? #2922

Merged
merged 11 commits into from
Mar 22, 2023
Merged

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Mar 15, 2023

draft because:

  • Android part is missing / broken
  • help/manual page update needed

Depends on #2913


Commits explained:

  1. Refactors the config param class already. Ini reading is now a method which simplifies the code alot and reduces the errors.
  2. Adds a new resolution setting to "Video" for enabling (ultra)widescreen mode.
  3. When a resolution is set through the settings the metrics are now faked. Improvies game compat because e.g. pictures are centered. Is not perfect.
  4. (adds Exit Game option)
  5. Adds support for new game specific settings in a EasyRPG.ini file in the game folder. There is no gui to configure this (not planned yet, this was faster) but can be used to configure how the engine behaves.

Possible keys in EasyRPG.ini @florianessl

[Game]
NewGame=1 <- Skip the title screen
FakeResolution=1 <- When WinW/WinH is used, enables 320x240 resolution faking
Engine=rpg2k <- Engine override (see --help for options)

[Patch] <- Patch override, keys named after the existing patches
Maniac=1
DynRPG=1
CommonThisEvent=1 <- This Event in Common Events, default in 2k3E
PicUnlock=1 <- Messages are non-blocking for pictures, default in 2k3E

This allows rendering the game at 16:9 (Widescreen) or 21:9 (Ultrawide)

This can obviously cause visual glitches in some games.
This forces e.g. pictures in a 320x240 fake-viewport to enhance game compatibility.

This is obviously not perfect but better than no faking.
@Ghabry Ghabry added RPG_RT Patches Has PR Dependencies This PR depends on another PR Settings All about customizable features, storing and applying them labels Mar 15, 2023
@Ghabry Ghabry added this to the 0.8.0 milestone Mar 15, 2023
@fdelapena fdelapena removed the Has PR Dependencies This PR depends on another PR label Mar 15, 2023
@Ghabry Ghabry force-pushed the resolution-config branch 3 times, most recently from 8bb063f to f8057c7 Compare March 16, 2023 21:51
@Ghabry Ghabry marked this pull request as ready for review March 16, 2023 21:52
@Ghabry
Copy link
Member Author

Ghabry commented Mar 16, 2023

Bet I will regret this soon but whatever:

image

@fdelapena fdelapena added the Awaiting Rebase Pull requests with conflicting files due to former merge label Mar 18, 2023
Is for managing game specific patch settings.

They must be provided in a "EasyRPG.ini" with the game.
A visual configuration in the settings scene later is possible.

Fix EasyRPG#1627
Fix EasyRPG#2182
Fix EasyRPG#2766
Adopt old settings to new names
@Ghabry Ghabry removed the Awaiting Rebase Pull requests with conflicting files due to former merge label Mar 20, 2023
@Ghabry
Copy link
Member Author

Ghabry commented Mar 20, 2023

Rebased and reapplied a commit that somehow got lost (was originally in "fixes" branch, must have deleted it by accident)

Copy link
Contributor

@fdelapena fdelapena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated features, and per-game ini settings is going to be so useful for game developers 👍.

@fdelapena fdelapena merged commit 7f9ac08 into EasyRPG:master Mar 22, 2023
@Ghabry Ghabry deleted the resolution-config branch June 12, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Refactor RPG_RT Patches Settings All about customizable features, storing and applying them
Development

Successfully merging this pull request may close these issues.

2 participants