Skip to content

Use more Exe information for the version detection #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2023
Merged

Use more Exe information for the version detection #2923

merged 1 commit into from
Mar 19, 2023

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Mar 16, 2023

wrote 90% of this code a year ago and just remembered that it exists.

Finished it. Please give it a test.

Useless for emscripten obviously.

The check is quite defensive so when there is anything that looks off the engine is reported as "None" and it uses the old check.

see FileInfo::GetEngineType() for the logic. Not explaining this again.

Also disabled the "heuristic" to detect 2k3 in the old codepath because this caused alot of problems because it only fixed .flow but broke many other games.

Detection results for some exes:

Debug: !! rpg2000/RPG_RT.2000.1.0.5.0.dons.eng.exe
Debug: version= logos=3 i386=true easyrpg=false
 
Debug: !! rpg2000/RPG_RT.2000.1.0.7.0.dons.eng.exe
Debug: version= logos=3 i386=true easyrpg=false
 
Debug: !! rpg2000/RPG_RT.2000.1.0.9.0.dons.eng.exe
Debug: version= logos=3 i386=true easyrpg=false
 
Debug: !! rpg2000/RPG_RT.2000.1.5.1.0.fdelapena.spa.cleartype.exe
Debug: version= logos=1 i386=true easyrpg=false
 
Debug: !! rpg2000/RPG_RT.2000.1.5.1.0.jp.exe
Debug: version= logos=1 i386=true easyrpg=false
 
Debug: !! rpg2000/RPG_RT.2000.1.5.1.0.rpghacker.eng.exe
Debug: version= logos=1 i386=true easyrpg=false
 
Debug: !! rpg2000/RPG_RT.2000.1.6.1.0.eng.exe
Debug: version=1.6.1.0 logos=1 i386=true easyrpg=false
 
Debug: !! rpg2003/RPG_RT.2003.1.0.3.0.jp.exe
Debug: version=1.0.3.0 logos=1 i386=true easyrpg=false
 
Debug: !! rpg2003/RPG_RT.2003.1.0.3.0.advocate.eng.exe
Debug: version=1.0.3.0 logos=1 i386=true easyrpg=false
 
Debug: !! rpg2003/RPG_RT.2003.1.0.8.0.vampires.dawn.II.unknown.eng.exe
Debug: version=1.0.8.0 logos=1 i386=true easyrpg=false
 
Debug: !! rpg2003/RPG_RT.2003.1.0.9.1.fdelapena.spa.cleartype.exe
Debug: version=1.0.9.1 logos=1 i386=true easyrpg=false
 
Debug: !! rpg2003/RPG_RT.2003.1.0.9.1.unknown.eng.exe
Debug: version=1.0.9.1 logos=1 i386=true easyrpg=false
 
Debug: !! rpg2003/RPG_RT.2003.1.1.2.0.eng.exe
Debug: version=1.1.2.0 logos=1 i386=true easyrpg=false
 
Debug: !! rpg2003/RPG_RT.2003.1.1.2.1.eng.exe
Debug: version=1.1.2.1 logos=1 i386=true easyrpg=false

@Ghabry Ghabry added this to the 0.8.0 milestone Mar 16, 2023
@Ghabry
Extract more information from RPG_RT.exe to make engine detection mor…
dc47d24 
…e reliable

Extracted are the VERSIONINFO and the amount of XYZ (logo) resources

Fix EasyRPG#2221
Fix EasyRPG#2606
Fix EasyRPG#2614

Related EasyRPG#2294 but not fixed because is about Emscripten
@fdelapena fdelapena added the Heuristics All detection related: encoding, version, etc. label Mar 16, 2023
@fdelapena fdelapena merged commit 1260232 into EasyRPG:master Mar 19, 2023
@Ghabry Ghabry deleted the exe-resource branch June 12, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelapena fdelapena fdelapena approved these changes

Assignees
No one assigned
Labels
Heuristics All detection related: encoding, version, etc.
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghabry @fdelapena