Windows fixes #2958
Merged
Windows fixes #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proper fix will be in SDL3 see EasyRPG#2764
Was ALL_BUILD before which fails when using "Run"
Otherwise corrupts heap memory on 32 Bit Windows. Not sure if we are to blame here or Pixman. Fix EasyRPG#2906
|
mimigris reported that no dump file is created for the OFF battle crash (and I can confirm this) but in other cases the dmp is created. Likely the heap corruption preventing the execution of our crash handler. |
fdelapena
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinApi for directory reading appears to work but would be good to have some others launch some games for testing.