Require C++17#2986
Merged
3 commits merged intoMay 22, 2023
Merged
Conversation
Fedora unbundles our dr_wav because they have a system header
Ghabry
force-pushed
the
cpp17
branch
2 times, most recently
from
63cf407 to
ec73a85
Compare
ghost
approved these changes
May 13, 2023
Member
Author
|
@fdelapena the mix of C++14 and C++17 (lcf / Player) makes the build fail for old Debian/Ubuntu versions. I think its better to just merge this and to cherry-pick the other commits in a |
ghost
merged commit
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Require C++17
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__has_include and [[maybe_unused]] are c++17 features so this will build-fail already when the compiler does not know it ;)