Emscripten: retry download on uncommon failure#3004
Merged
Conversation
From ynoclient: ynoproject/ynoengine@095cf5b TCP connections aren't reliable!
ghost
requested a review
from 
Member
|
Thanks for the patch. A good test for this is likely simulating a bad wi-fi connection / mobile connection. E.g. disconnect the WiFi and then reconnect it after a few seconds. Will test this later :) |
ghost
added
the
Ghabry
approved these changes
Jun 5, 2023
ghost
approved these changes
Jun 5, 2023
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Emscripten: retry download on uncommon failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From ynoclient: ynoproject/ynoengine@095cf5b
TCP connections aren't reliable!