Fix Samsung Multitouch bug#3016
Merged
1 commit merged intoMay 31, 2023
Merged
Conversation
Member
Author
|
Received positive feedback from another Samsung user (mokodeoz). Waiting for non-Samsung feedback, too :) |
This happens when a game is running (GlSurface exists) and a touch happens across different views. Our touch ui uses one view per button and is affected. The culprit is a game optimisation that reduces the size of the surface. Fix is based on https://github.com/F0RIS/SamsungMultitouchBugSample/tree/Fix1 See also: Swordfish90/Lemuroid#178 Fix EasyRPG#2830 Fix EasyRPG#2915
Ghabry
force-pushed
the
android/samsung-touchbug
branch
from
3b9b4e2 to
2f8c13b
Compare
ghost
approved these changes
May 24, 2023
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty annoyed right now but I think this is working >.>
Please also test on other devices to ensure my heuristic does not cause fall-positives.
This happens when a game is running (GlSurface exists) and a touch happens across different views.
Our touch ui uses one view per button and is affected.
The culprit is a game optimisation that reduces the size of the surface.
Fix is based on https://github.com/F0RIS/SamsungMultitouchBugSample/tree/Fix1
See also: Swordfish90/Lemuroid#178
Fix #2830
Fix #2915