Widescreen improvements#3030
Merged
9 commits merged intoEasyRPG:masterfrom Jul 28, 2023
Merged
Conversation
…e not shared. Should be slightly faster. Modernize code.
…when leaving the settings
For this a new render_ox and render_oy are introduced whose only purpose is storing this offset. Could not use ox/oy as these are already used by the sprites for other purposes.
This happens when the map is smaller than the viewport on higher resolutions.
Member
Author
|
There is one annoyance left: On looping maps that are smaller than the screen the camera is positioned incorrectly. Unfortunately cannot figure out how to solve this. The scrolling code is complicated ^^' |
Contributor
|
Looking good besides the mentioned by Mimigris, however there are some cases for new games where some picture behaviour is desired with the legacy way, e.g. for custom HUD positioned on screen corners. Maybe getting this under some configurable feature later is worth. |
ghost
approved these changes
Jul 3, 2023
Not implemented for Battle 2k3 yet because the Ui is much more complicated.
Member
Author
|
ready now. Fixed centering for battle animations and zoom on actor. 2k battle Ui is not scrolling anymore in widescreen mode. For 2k3 I will postbone this for later as this requires implementing it 3 times for all these modes... |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Like everything else the map is now centered when fake resolution is active. Should improve the UX because it gets rid of some glitches :).
First two commits are not changing any behaviour.
3rd commit allows to change the resolution while in the title scene. Until now this didn't work without: Start game, press F12.
4th and 5th commit: 4th results in the screenshot in the middle and 5th results in the screenshot at the bottom. (top is before) Cropping the panorama makes sense here because technically it is drawn outside of the size of the map, nothing should be drawn their.
Another example using Fake Res for a custom resolution. That map is again 20x15. Cropping works.