Skip to content

Widescreen improvements#3030

Merged
9 commits merged intoEasyRPG:masterfrom
Ghabry:widescreen
Jul 28, 2023
Merged

Widescreen improvements#3030
9 commits merged intoEasyRPG:masterfrom
Ghabry:widescreen

Conversation

@Ghabry
Copy link
Copy Markdown
Member

@Ghabry Ghabry commented Jun 5, 2023

Like everything else the map is now centered when fake resolution is active. Should improve the UX because it gets rid of some glitches :).

First two commits are not changing any behaviour.

3rd commit allows to change the resolution while in the title scene. Until now this didn't work without: Start game, press F12.

4th and 5th commit: 4th results in the screenshot in the middle and 5th results in the screenshot at the bottom. (top is before) Cropping the panorama makes sense here because technically it is drawn outside of the size of the map, nothing should be drawn their.

out2

Another example using Fake Res for a custom resolution. That map is again 20x15. Cropping works.

out

Ghabry added 4 commits May 26, 2023 11:09
…e not shared.

Should be slightly faster.

Modernize code.
For this a new render_ox and render_oy are introduced whose only purpose is storing this offset.

Could not use ox/oy as these are already used by the sprites for other purposes.
@Ghabry Ghabry added this to the 0.8.0.1 milestone Jun 5, 2023
Ghabry added 2 commits June 5, 2023 23:41
This happens when the map is smaller than the viewport on higher resolutions.
@Ghabry
Copy link
Copy Markdown
Member Author

Ghabry commented Jun 5, 2023

There is one annoyance left: On looping maps that are smaller than the screen the camera is positioned incorrectly. Unfortunately cannot figure out how to solve this. The scrolling code is complicated ^^'

@ghost ghost added the UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design label Jun 6, 2023
@Mimigris
Copy link
Copy Markdown
Contributor

  • The transitions Zoom In and Zoom Out are not properly centered on the player on small maps (shown here with Deep Dreams, first screen is the original resolution and second screen is widescreen)
    screenshot_2
    screenshot_3
  • The battle animations are not properly centered on the player/target on small maps (shown here with Yume Nikki, first screen is the original resolution and second screen is widescreen)
    screenshot_75
    screenshot_74
  • The artifacts of some transitions can be shown outside of the size of the map, not sure if it's intended (Need more testing I guess)

Outside of this, the only thing that may need to be changed is how the battle UI is rendered I guess since it's a bit weird, though I'm not sure how it could be done correctly.

@ghost
Copy link
Copy Markdown

ghost commented Jul 3, 2023

Looking good besides the mentioned by Mimigris, however there are some cases for new games where some picture behaviour is desired with the legacy way, e.g. for custom HUD positioned on screen corners. Maybe getting this under some configurable feature later is worth.

Not implemented for Battle 2k3 yet because the Ui is much more complicated.
@Ghabry
Copy link
Copy Markdown
Member Author

Ghabry commented Jul 25, 2023

ready now. Fixed centering for battle animations and zoom on actor.

2k battle Ui is not scrolling anymore in widescreen mode. For 2k3 I will postbone this for later as this requires implementing it 3 times for all these modes...

@ghost ghost merged commit 4cacbbb into EasyRPG:master Jul 28, 2023
@Mimigris Mimigris mentioned this pull request Aug 1, 2023
2 tasks
@Ghabry Ghabry deleted the widescreen branch September 2, 2024 18:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design

Development

Successfully merging this pull request may close these issues.

2 participants