Skip to content

Custom Logos at Startup#3096

Merged
Ghabry merged 7 commits into
EasyRPG:masterfrom
EasyRPG-NewFeatures:custom-logo
Oct 21, 2023
Merged

Custom Logos at Startup#3096
Ghabry merged 7 commits into
EasyRPG:masterfrom
EasyRPG-NewFeatures:custom-logo

Conversation

@jetrotal

@jetrotal jetrotal commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

To add custom logos, you need to add image files named LOGO1, LOGO2, LOGO3, LOGOn to the Font folder.
It will always load the next logo file, while sequential files exist in the Font folder.

You can skip having LOGO0, it loads default easyRPG logo when LOGO0 doesn't exists.
EasyRPG logo is always displayed at bootup, to avoid a blank screen while loading a heavy game.

Some reference files for testing:

LOGO1
LOGO2
LOGO3

You must add images named LOGO0, LOGO1, LOGO2, LOGOn to the Font folder.
it will stop showing logos whenever it fails to find a file.

Update scene_logo.cpp
@Mimigris

Copy link
Copy Markdown
Contributor

From a quick test:

  • I'm unable to replace the LOGO0 on my side, it is completely ignored and not read at all
  • Holding Shift while the other logos are displayed will wait until you no longer hold it to go to the next scene, as a leftover of the version details present on the default scene, I'm not sure if it should be kept?
  • The v0.8 line without the details is not erased when pressing Shift, so it is then weirdly displayed (look at v0.8)
    screenshot_2

Didn't tested more outside of that, but that seems promising 👍

Comment thread src/scene_logo.cpp Outdated
@Ghabry

Ghabry commented Sep 26, 2023

Copy link
Copy Markdown
Member

Also for discussion: Is Font\LogoN a good location for this? Are there better folder suggestions? Seperate Logo folder?

- Add custom functions preloadLogos() and DetectGame() to keep it easy to read and maintain.

- DetectGame() only happens after loading the Default EasyRPG logo. This happens to avoid a blank screen while loading game assets, as suggested by @Ghabry

- Disable the shift key behavior when not at LOGO0.

- Fix webplayer issue by adding the prefix ` Scene_Logo::` to the new functions.

------------------------

I guess this solves the issues? Lemme know if you guys need anything else.
Better for reading and organization.
@jetrotal jetrotal changed the title Jetrotal - Custom Logos on Startup Custom Logos at Startup Sep 26, 2023

@Ghabry Ghabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote the logo loading logic to always only load one logo and I got rid of global state. The remaining technique (such as invoking another logo scene) remained the same.

Is now much faster when loading 200 logos :P. There is no upper limit.

@jetrotal

Copy link
Copy Markdown
Contributor Author

I rewrote the logo loading logic to always only load one logo and I got rid of global state.

Thanks! When I use the flag --new-game with the 200+ logo collection, it gets stuck at the logos screen for some time.

Could a skip after the first be added in this specific case?

@Ghabry

Ghabry commented Oct 21, 2023

Copy link
Copy Markdown
Member

Right. The same will happen when running in test game mode. Will add a fix.

The engine objects are created by then so this is safe
@Ghabry

Ghabry commented Oct 21, 2023

Copy link
Copy Markdown
Member

The logos are now correctly skipped when TestPlay or BattleTest are used. --new-game will only skip it in combination with one of them (like before).

@MesaBlack

Copy link
Copy Markdown

how about a custom video at startup?

@Mimigris

Copy link
Copy Markdown
Contributor

how about a custom video at startup?

At this point, you could probably skip the title screen in your game and manually create a video on your side when starting the game, it would probably be better to do it this way.

@Ghabry Ghabry added this to the 0.8.1 milestone Oct 21, 2023
@Ghabry
Ghabry merged commit 75d3515 into EasyRPG:master Oct 21, 2023
@jetrotal
jetrotal deleted the custom-logo branch August 4, 2024 23:57
sevenc-nanashi pushed a commit to sevenc-nanashi/easyrpg-player that referenced this pull request May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants