Add nlohmann json, remove picojson - #3228
Merged
Merged
Conversation
Is enabled for all platforms because this will be used by a JSON event command. (also dropped rang from the license screen, we forgot to delete it earlier)
carstene1ns
reviewed
May 20, 2024
Member
Author
|
Quick size benchmark: Moving to nlohmann_json increased the binary size of the WASM file by 34 KB. (at least for the stripped release WASM file, for the debug file it is +1 MB 😰 ) |
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Add nlohmann json, remove picojson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is enabled for all platforms because this will be used by a JSON event command (#3215)
Used the opportunity to get rid of picojson :) (one less vendored dep, only dr_wav left xD)