Android: Add LZH support, refactor GameBrowser Game Searching#3230
Merged
26 commits merged intoAug 25, 2024
Merged
Conversation
Reduces confusion in Weblate due to the Read only strings.
Can be added in the Layout editor.
To be used by the Android GameBrowser
The JNIEnv-Pointer is now set from the outside. Makes it possible to call these functions without having SDL initialized. Remove DeleteLocalRef, as these references are garbage collected automatically when the function returns.
…ser. Allows to drop most of the Java scanning code and makes maintanance easier.
This also allows stuff like multiple games in a single zip, zip inside zip etc.
Member
Author
|
Well this is ready. Happy testing/crashing the Android Player xD
|
Ghabry
marked this pull request as ready for review
May 23, 2024 13:53
1. If only one title image: Use this one 2. By parsing the database 3. By taking the first image in the title folder This approach is surprisingly fast and the caching skips the scan after the first time.
The title is then reencoded based on the users encoding setting.
Member
Author
|
@fdelapena suggested to grab the game title from the INI as I'm already parsing the folder anyway. This went a bit down the rabbit hole then because my code already failed to guess the encoding of the title string of Yume2kki (ゆめ2っき) correctly. So I added two workarounds:
|
Member
Author
|
|
Also minor Soundfont code fixes
Hide Soundfont and Font settings on Android in general (thx SAF)
Originally they were generated by a Header generator but by now Android Studio handles this which is more flexible.
carstene1ns
approved these changes
Jun 10, 2024
ghost
added
the
Awaiting Rebase
ghost
approved these changes
Jul 2, 2024
Ghabry
removed
the
Awaiting Rebase
Member
Author
|
okay rebased. Also added the Font preview and the RTP status commits as previously discussed in the AudioCfg PR. Happy testing. ;)
|
Member
|
I think we should merge this and push to the beta channel to get more feedback. |
Member
Author
|
Made a small fix to the save path code and had to bump the target SDK because we are behind... Is ready for merge now. |
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Android: Add LZH support, refactor GameBrowser Game Searching
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.