Fix compilation errors when Resamping is disabled#3251
Merged
Conversation
Member
|
This should not really be necessary, since the used functions have these guards as well. |
Contributor
Author
|
I did not try the cmake but i was trying with the old makefile and disabling WildMidi and fluidsynth and i was getting those errors otherwise (when not left enabled). Pretty clear to me looking at the rest of this file in question that this is not the only place where fluidsynth code... is being encapsulated behind ifdefs. |
Contributor
Author
|
I checked with Fluidlite and i have not fixed all issues... This happens if the resampler is not enabled but fluidlite or fluidsynth are. Don't merge this yet, i will address this issue. |
57db6fd to
cf0377a
Compare
Member
|
With the moved included file is the rest still needed? |
Member
|
For me this works just with the relocated include. |
ghost
approved these changes
Aug 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If either of these is disabled in a Makefile, then it will result in errors during compiling.