Migrate to std::string_view, liblcf #495#3360
Merged
Merged
Conversation
github-actions
Bot
added
Android
Window/Scenes
FileFinder
Bitmaps
Audio
Fonts
Battle
Emscripten
Ghabry
removed
Android
Window/Scenes
FileFinder
Bitmaps
Audio
Fonts
Battle
Emscripten
Ghabry
added
Has PR Dependencies
ghost
approved these changes
Mar 3, 2025
florianessl
reviewed
Mar 9, 2025
Ghabry
force-pushed
the
stringview
branch
2 times, most recently
from
March 10, 2025 12:04
63b5302 to
4fa6d98
Compare
florianessl
approved these changes
Mar 10, 2025
Member
Author
|
@florianessl can you do a compile (a short functionality test) on Windows again? I already tested config reading/writing with ASAN enabled on Linux so it should work ™️ |
Member
Already have! |
ghost
approved these changes
Mar 12, 2025
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Migrate to std::string_view, liblcf EasyRPG#495
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StartsWith/EndsWithneeded manual work, rest was Search/Replace.