Repository navigation
Libretro fixes and one hotfix for YNOnline Users with loooong playtimes - #3385
Conversation
This is only used by our app for certain functionality.
Otherwise the arrays will index out of bounds when the frame counter overflows. Discovered via the YNOOnline project were savegames that are used for multiple years can happen :)
|
This seems to work well 👍 |
|
I meant I did a test locally where I altered the frame counter in such a way that it will overflow two seconds after selecting "new game" to simulate what happens. The frame counter overflowing has no negative impact. It could be that for a brief moment (during the overflow) that an animation advances faster but otherwise there will be no negative things happening. That frame counter is never used for any timedelta calculations, so "begin > end" cannot happen. For all other time measurement we use a different frame counter that always starts at 0 so for this to overflow the Player must really run for 1.5 years without reloading the website :D. |
Libretro fixes and one hotfix for YNOnline Users with loooong playtimes
Guess @Mimigris should also test this a bit.
I only hacked the frame counter to overflow after about two seconds. Works for me (it renders are usual, thats not the RPG_RT behaviour but who cares).