Compiler fixes#3397
Merged
Merged
Conversation
Though I had already resolved this months ago but forgot to commit it.
Is unstable and in general recommended to be disabled on Vita. Makes our code crash at the end of the MainLoop.
ghost
approved these changes
Apr 15, 2025
ghost
added
the
Ghabry
marked this pull request as draft
April 16, 2025 15:07
Ghabry
marked this pull request as ready for review
April 24, 2025 10:38
Ghabry
marked this pull request as draft
April 24, 2025 10:40
Multi config is not supported and only gives linker errors because of mixed runtime libraries.
Ghabry
marked this pull request as ready for review
April 24, 2025 10:53
Member
Author
|
I must have forgotten to commit the |
carstene1ns
approved these changes
Apr 24, 2025
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Compiler fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a dumb typo in the Presets breaking RelWithDebInfo (Making it a Debug build >.>).
And Rinnegatamante told me to pass
-fno-optimize-sibling-callsfor the Vita build because that optimisation can cause crashes: Can confirm. With that flag set the MainLoop does not randomly crash anymore 🤷 (that appears to be a general problem on Vita, other homebrew uses the same flag)