Android: Fix all the crap required since Android 15 (Edge-To-Edge, Back callbacks). - #3408
Merged
Conversation
To achieve this a custom ScrollView was added which configures the insets and draws the systembar color. The code was based on the AndroidX DrawerLayout but using this directly was risky as it has too many features we don't use. Fix EasyRPG#3373
…also works for older ones) Otherwise the app is terminated instead of opening our Drawer. onBackPressed is depreacted. Instead a callback must be added to getOnBackPressedDispatcher (what an improvement, incredible!)
Otherwise the default buttons are partially rendered out of bounds... Was figured out via trial and error. Works on my device...
Ghabry
added
Android
UX
carstene1ns
approved these changes
May 2, 2025
carstene1ns
left a comment
carstene1ns
left a comment
Member
There was a problem hiding this comment.
Tested on Android 9, seems to work.
sevenc-nanashi
pushed a commit
to sevenc-nanashi/easyrpg-player
that referenced
this pull request
May 31, 2026
Android: Fix all the crap required since Android 15 (Edge-To-Edge, Back callbacks).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All this huge pile of disgusting code just to get rid of bad defaults enforced by Google we don't even use. Please don't ask about too many details... It uuuuh works.
(Fun fact: They delayed the opt-out to Android 16 because even Google itself hasn't added it to all their apps yet m( )
For testing you need a Android 15+ device. On olders you can only test if it still works, but all the edge-to-edge stuff etc. is just disabled.
Oh and I also added a Dark Mode :). At least something that is useful.