Several fixes for the CloneMapEvent/DestroyMapEvent commands

[florianessl]

Fixes following issues with these EasyRPG-commands:

• Cloned & destroyed events were not considered by the map setup code which is responsible for loading savegame data. This was especially dangerous if a pre-existing map event has been destroyed because the code assumed both the original & the savegame data vectors of events to be both the same size & in the same order, with no skipping of IDs.
• Added check before refresh of "scene": If the CloneMapEvent function was called from inside the map setup code, the map scene might not be created yet.
• Fix EasyRPG-exclusive command "DestroyMapEvent": "ThisEvent" not supported #3393
• Sometimes CloneMapEvent would write garbage data into the field "easyrpg_clone_event_id" due to an invalid pointer (Vector reallocation issue)

Test project:

CloneDestroyMapEventTest.zip

[Ghabry]

btw you can add a new chunk for this. Just won't be fixed as part of the patch release as we don't bump liblcf.

[Ghabry]

The "Clone Event" upon load will likely fail in the web player because of async fetch requirements when the map is different but I don't see a simple solution for this right now :/

[Ghabry]

Because this is loading code I don't want that it crashes for the user so I added another range check and removed the assert.

@florianessl could you quickly test this again with some games (and with your Clone Destroy Event stuff xD)

[florianessl]

Well, it looks like it works fine with Urban Purrrge. And that game spawns 1000s of mobs & blood stains :D
I had the event counter overflow several times to test this out. (enemies will spawn indefinitely & just override previous ones when the upper ID limit is reached)

https://rmarchiv.de/games/3694

[Ghabry]

Okay I think this received enough testing. Gonna merge it.